-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24552/
-----------------------------------------------------------
Review request for cloudstack, Gaurav Aradhye and Santhosh Edukulla.
Bugs: CLOUDSTACK-7307
https://issues.apache.org/jira/browse/CLOUDSTACK-7307
Repository: cloudstack-git
Description
-------
See full explanation and justification of this patch on the ticket at
https://issues.apache.org/jira/browse/CLOUDSTACK-7307
A brief summary is that a number of tests require the simulator (e.g. to check
the behaviour in a failure condition).
The existing attempt at solving this issue involved setting the
required_hardware attribute to "simulator only", however
this is not very easy to use with the nosetests runner due to limitations it
has around handling attributes. By adding a
new attribute (simulator_only), we can simply add !simulator_only to an
attribute listing to avoid running these tests.
Diffs
-----
test/integration/smoke/misc/test_deploy_vm.py 071d15d
test/integration/smoke/misc/test_vm_ha.py 601354e
test/integration/smoke/test_vm_sync.py 6d56945
Diff: https://reviews.apache.org/r/24552/diff/
Testing
-------
Verified that tests are picked up when run without the new attribute, and not
picked up when used with !simulator_only in the nosetests -a attribute list.
Thanks,
Alex Brett
