----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24544/#review50421 -----------------------------------------------------------
Commit 9d7b85153747dfe378031455fc1231bcd6088d08 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9d7b851 ] CLOUDSTACK-7294: Passing listall=True for listUser api admin call - ASF Subversion and Git Services On Aug. 11, 2014, 10:20 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24544/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 10:20 a.m.) > > > Review request for cloudstack, Doug Clark and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7294 > https://issues.apache.org/jira/browse/CLOUDSTACK-7294 > > > Repository: cloudstack-git > > > Description > ------- > > According to API changes > (https://cwiki.apache.org/confluence/display/CLOUDSTACK/List*+API+commands+rules), > listall parameter is necessary when admin wants to list the resources which > belong to some other account. > > Adding domainid and listall parameter while making listUsers api call through > admin. > > > Diffs > ----- > > tools/marvin/marvin/cloudstackTestClient.py 1ca79ee > > Diff: https://reviews.apache.org/r/24544/diff/ > > > Testing > ------- > > Yes. > > Tested two failing test cases with this change. > > Test Deploy VM with 4 core CPU & verify the usage ... === TestName: > test_01_multiple_core_vm_start_stop_instance | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 1 test in 627.195s > > OK > > > @summary: Test List IP Addresses pagination ... === TestName: > test_01_list_ipaddresses_pagination | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 1 test in 32.022s > > OK > > > Thanks, > > Gaurav Aradhye > >
