----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24644/#review50446 -----------------------------------------------------------
Commit 525ee4a4aada2aa90bf53b301151f20111788e65 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=525ee4a ] CLOUDSTACK-7329: Fixed issues in test_region_vpc.py Signed-off-by: Santhosh Edukulla <santhosh.eduku...@gmail.com> - ASF Subversion and Git Services On Aug. 13, 2014, 11:08 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24644/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 11:08 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7329 > https://issues.apache.org/jira/browse/CLOUDSTACK-7329 > > > Repository: cloudstack-git > > > Description > ------- > > 1) Fixed imports > 2) Changed the services input, it should be read from the test case itself > 3) Corrected the attribute names > 4) Removed unused variables > 5) Added check for OVS network service provider is enabled or not. Skip the > test case if it is not enabled, in that case creating region level VPC is not > possible. > > > Diffs > ----- > > test/integration/component/test_region_vpc.py e348065 > > Diff: https://reviews.apache.org/r/24644/diff/ > > > Testing > ------- > > Yes: > > I have tested on setup with Ovs disabled. > > Log: > Test create VPC offering ... === TestName: > test_01_create_vpc_offering_with_regionlevelvpc_service_capability | Status : > SUCCESS === > ok > Test create VPC offering ... SKIP: OVS plugin should be enabled to run this > test case > Test deploy virtual machines in VPC networks ... SKIP: OVS plugin should be > enabled to run this test case > > ---------------------------------------------------------------------- > Ran 3 tests in 16.914s > > OK (SKIP=2) > > > Thanks, > > Gaurav Aradhye > >