----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23150/#review50963 -----------------------------------------------------------
Ship it! applied to master and merged in 4.4 for 4.4.1 release Please mark the review as submitted. thanks for the patch - Sebastien Goasguen On June 30, 2014, 8:53 a.m., Olivier Lemasle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23150/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 8:53 a.m.) > > > Review request for cloudstack, Kishan Kavala and Sebastien Goasguen. > > > Bugs: CLOUDSTACK-7006 > https://issues.apache.org/jira/browse/CLOUDSTACK-7006 > > > Repository: cloudstack-git > > > Description > ------- > > This patch restore the template ID in usages, for ROOT volume created from a > template (see CLOUDSTACK-7006). > > The regression was on the class com.cloud.storage.VolumeManagerImpl (module > "cloud-server") but it has been renamed > org.apache.cloudstack.engine.orchestration.VolumeOrchestrator (module > "cloud-engine-orchestration"). > > The patch applies on branchs master and branch 4.4. > I've attached another patch for branch 4.3 (the only difference is > formatting). > > > Diffs > ----- > > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java > 9ba3451 > > Diff: https://reviews.apache.org/r/23150/diff/ > > > Testing > ------- > > Tested in ACS 4.3. > 1. Deploy a new VM from a template. > 2. Check if usages for the ROOT volume has the right templateId. > 3. Deploy a new VM from an ISO, and add a DATA volume. > 4. Check that there is no regression for these two types of volume usages > without templateId. > > > File Attachments > ---------------- > > patch version for ACS 4.3 > > https://reviews.apache.org/media/uploaded/files/2014/06/29/eee8a901-4141-46e7-b4ce-d9cbcfd8c85f__cloudstack-7006-for-ACS4.3.patch > > > Thanks, > > Olivier Lemasle > >
