@Rohit I think we are playing with fire here a bit. DB changes should be made on major releases and we should try to avoid DB changes on minor releases because of this type of problem. We have to keep the upgrade paths as clean as possible because we don't want people running into issues when they upgrade their prod boxes.
I think we are going to have a problem with this one because I think the 4.4.1 branch is going to be released before the 4.3.1 branch, so the upgrade path will be broken. My understanding is that the 4.4.1 branch is planned to be launched on Monday (Sept 8th), so I expect there will be a problem with the upgrade path if we implement this change in 4.3.1. Thats my two cents anyway... @Rajani I am not entirely sure which technology is being used for the db upgrade paths, but I think it is probably something like liquibase already. I would have to check on the technology, but this is already in place. The issue is more about maintaining an upgradeable path for each version that is released. This is a bit complicated by the fact that we currently have 4.3, 4.4 and 4.5 version all having changes made to them at the same time... *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Sep 2, 2014 at 11:28 AM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote: > > On 02-Sep-2014, at 5:07 pm, Francois Gaudreault <fgaudrea...@cloudops.com> > wrote: > > I see. Well, I think we were impacted by that too, and we made the > decision to move on 4.4.1-snap (even if it's technically less stable?) and > then upgrade to 4.4.1 GA (next week?) > > > > I personally don't think pulling back DB changes in lower releases is a > good idea :S > > > > But that's only my opinion :) > > I raised a concrete issue regarding 4.3.1/4.4.1 release and I would like > to stick to that only. I understand there are too many numbers, versions > and branches to follow, so please if you can try to understand the issue; > > This issue — https://issues.apache.org/jira/browse/CLOUDSTACK-6756 > requires that there are some extra columns in the database to do book > keeping when delete ips so you don’t actually delete db/table rows. > > The issue above is fixed in an upgrade path from 4.3.0 to 4.4.0: > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=setup/db/db/schema-430to440.sql;h=226260804523c79e3ce3cfa3c407b5ac698d749c;hp=3b525c41a1befd94c5ffc324c357b566606a97d0;hb=ce6a53e;hpb=d0f806b3a486c58b033083fc57f39dd686e31750 > > But, we already have 4.4.0 release and db upgrade paths are always in the > next release versions. > > So, there is no upgrade path from 4.3.1 to 4.4.0; as 4.3.1 version does > not care about 4.4.0 schema changes. There is only an upgrade path from > 4.3.0 to 4.3.1. So, the limitation is that people won’t be able to upgrade > from 4.3.1 to 4.4.0, because 4.4.0 is already released. > > If we release 4.4.1 before 4.3.1, we’ll have the same issue. So, we can > put the fix from the JIRA issue on 4.3 branch so the issue is fixed for > 4.3.1. The fix will be in the 4.3.0 to 4.3.1 upgrade path. And, if we > release 4.4.1 after 4.3.1, we can fix the upgrade path from 4.3.1 to 4.4.1 > on 4.4 branch such that > > The abstract issue is — we’ll have such issue in future, how do we fix it. > I suggested — we make a separate tool that does (rolling) upgrades. > > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +41 779015219 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter: @_bhaisaab > > > > Find out more about ShapeBlue and our range of CloudStack related services > > IaaS Cloud Design & Build< > http://shapeblue.com/iaas-cloud-design-and-build//> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > CloudStack Infrastructure Support< > http://shapeblue.com/cloudstack-infrastructure-support/> > CloudStack Bootcamp Training Courses< > http://shapeblue.com/cloudstack-training/> > > This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Shape Blue Ltd or related companies. If you are not the > intended recipient of this email, you must neither take any action based > upon its contents, nor copy or show it to anyone. Please contact the sender > if you believe you have received this email in error. Shape Blue Ltd is a > company incorporated in England & Wales. ShapeBlue Services India LLP is a > company incorporated in India and is operated under license from Shape Blue > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil > and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is > a company registered by The Republic of South Africa and is traded under > license from Shape Blue Ltd. ShapeBlue is a registered trademark. >
