----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22713/ -----------------------------------------------------------
(Updated Sept. 15, 2014, 11:41 p.m.) Review request for cloudstack, edison su, Min Chen, Prachi Damle, and Santhosh Edukulla. Changes ------- - Moved out the data used by test suite from Sevices object with in the test suite to test_data.py - Changed the tags for test cases - required_hardware="false" to be picked up by simulator runs. - Replaced try and except block such that the self.fail() statement is moved inside the try block. Also using self.fail() instead of raising exception when error message validation fails - Added Acl related error messages as constants to CloudstackAclException() and referred to these constants instead of using hardcoded strings Repository: cloudstack-git Description ------- This Test suite has test cases for deploying Virtual Machine using impersonation (passing account and domainId parameters) for shared network Diffs (updated) ----- test/integration/component/test_acl_sharednetwork_deployVM-impersonation.py PRE-CREATION tools/marvin/marvin/cloudstackException.py 331ae91 tools/marvin/marvin/config/test_data.py 4133aba Diff: https://reviews.apache.org/r/22713/diff/ Testing (updated) ------- Test Suite was executed against a management server built from 4.4-forward branch using a simulator set up: test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_account_user (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_user | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_subdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_subdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_subdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_subdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_parentdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_parentdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_parentdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_parentdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_subdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_subdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_subdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_subdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_differentdomain (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_differentdomain | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_user (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_account_user | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_crossdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_crossdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_subdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_subdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_subdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_all_subdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_parentdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_parentdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_parentdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_parentdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_subdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_subdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_subdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_nosubdomainaccess_subdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_ROOTuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_ROOTuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_domainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_domainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_domainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_domainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_parentdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_parentdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_parentdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_parentdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_subdomainadminuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_subdomainadminuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_subdomainuser (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_domainadmin_scope_domain_withsubdomainaccess_subdomainuser | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_regularuser_scope_all_anotherusersamedomain (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_regularuser_scope_all_anotherusersamedomain | Status : SUCCESS === ok test_deployVM_in_sharedNetwork_as_regularuser_scope_all_crossdomain (integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork) ... === TestName: test_deployVM_in_sharedNetwork_as_regularuser_scope_all_crossdomain | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 51 tests in 197.482s OK Thanks, sangeetha hariharan
