> On Sept. 19, 2014, 4:09 p.m., Mike Tutkowski wrote: > > Ship It!
I committed this under SHA dd4f6bcaf3a380e52c987e4a400fce09fb180006 and I resolved and closed the following JIRA ticket for you: https://issues.apache.org/jira/browse/CLOUDSTACK-7570 Thanks for finding and fixing this issue, Punith! - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25732/#review54035 ----------------------------------------------------------- On Sept. 17, 2014, 6:28 a.m., punith s wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25732/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 6:28 a.m.) > > > Review request for cloudstack and Mike Tutkowski. > > > Bugs: CLOUDSTACK-7570 > https://issues.apache.org/jira/browse/CLOUDSTACK-7570 > > > Repository: cloudstack-git > > > Description > ------- > > this bug will only occur in the following scenario > 1> create a compute offering with custom mode but not custom IOPS > 2> input the required min and max IOPS > 3> now create a VM based on the created compute offering > > issue: > ServiceOfferingVO dummyoffering = new ServiceOfferingVO(serviceOffering); > this constructor is not setting the min and max IOPS for the dummyoffering > > fix: > adding the min and max iops to the following constructor. > > > Diffs > ----- > > engine/schema/src/com/cloud/service/ServiceOfferingVO.java df68fb8 > engine/schema/src/com/cloud/storage/DiskOfferingVO.java 152fa2c > > Diff: https://reviews.apache.org/r/25732/diff/ > > > Testing > ------- > > system testing done > > > Thanks, > > punith s > >
