-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review54047
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/25647/#comment93968>

    Is this fix only for managed storage?
    
    From what I understand, the same issue exists for non-managed storage, but 
non-managed storage usually works because the template is being copied down to 
a shared storage repository that is typically quite a bit larger than the size 
of the template.
    
    For non-managed storage, however, if we were running low on space in a 
given storage repository, we might try to copy the template down to this 
storage repository thinking the template is smaller than it actually is and 
this process could fail.


- Mike Tutkowski


On Sept. 17, 2014, 6:22 a.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 6:22 a.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: 7406
>     https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> since cloudstack is not able to process the S3 or Switf templates for its 
> virtual size(root disk size), admin is facing issues while creating a vm 
> using third party storage plugins like cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable 
> ismanagedstorage = true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the 
> admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> -------
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>

Reply via email to