----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25934/#review54657 -----------------------------------------------------------
Ship it! Committed in 4eeae5ad51ce8d35701509cde9b99cee4ecaccc7 - Devdeep Singh On Sept. 23, 2014, 9:30 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25934/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 9:30 a.m.) > > > Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-7610, CLOUDSTACK-7611 and CLOUDSTACK-7612 > https://issues.apache.org/jira/browse/CLOUDSTACK-7610 > https://issues.apache.org/jira/browse/CLOUDSTACK-7611 > https://issues.apache.org/jira/browse/CLOUDSTACK-7612 > > > Repository: cloudstack-git > > > Description > ------- > > Fixed following bugs in AlertsSyslogAppender > 1. Added sync alert. > 2. Changed unrecognised alerts are send as unknown instead of null. > 3. Added unit tests to cover some more scenarios. > > > Diffs > ----- > > > plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java > 5f6e8ec > > plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java > 5799348 > > Diff: https://reviews.apache.org/r/25934/diff/ > > > Testing > ------- > > Added unit tests and all were passing fine > > > Thanks, > > Anshul Gangwar > >
