> On Oct. 1, 2014, 8:28 p.m., Rohit Yadav wrote: > > ui/dictionary.jsp, line 967 > > <https://reviews.apache.org/r/26220/diff/1/?file=710035#file710035line967> > > > > Why remove this?
Duplicated on line 969 > On Oct. 1, 2014, 8:28 p.m., Rohit Yadav wrote: > > client/WEB-INF/classes/resources/messages.properties, line 2039 > > <https://reviews.apache.org/r/26220/diff/1/?file=710034#file710034line2039> > > > > Titlecase? Detached? This is what we originally had in storage.js (See commit e3b5b213faf7fd89dfae024e129e2e7e55db898d). However, it makes sense to change it to "Detached". I will update the diff. - Mihaela ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26220/#review55120 ----------------------------------------------------------- On Oct. 1, 2014, 9:08 a.m., Mihaela Stoica wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26220/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 9:08 a.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Bugs: CLOUDSTACK-7596, CLOUDSTACK-7597, CLOUDSTACK-7606, CLOUDSTACK-7607, > CLOUDSTACK-7608, and CLOUDSTACK-7645 > https://issues.apache.org/jira/browse/CLOUDSTACK-7596 > https://issues.apache.org/jira/browse/CLOUDSTACK-7597 > https://issues.apache.org/jira/browse/CLOUDSTACK-7606 > https://issues.apache.org/jira/browse/CLOUDSTACK-7607 > https://issues.apache.org/jira/browse/CLOUDSTACK-7608 > https://issues.apache.org/jira/browse/CLOUDSTACK-7645 > > > Repository: cloudstack-git > > > Description > ------- > > - removed duplicate entries in dictionary > - added dictionary entries that have been missed during the dictionary split > - added missing entries in messages.properties > - fixed other localization issues > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties c9eb7ae > ui/dictionary.jsp c03ad67 > ui/dictionary2.jsp 39299b3 > ui/scripts/configuration.js b6c94f8 > ui/scripts/storage.js 783633c > ui/scripts/templates.js 9665ffd > ui/scripts/ui-custom/physicalResources.js 7dd5380 > > Diff: https://reviews.apache.org/r/26220/diff/ > > > Testing > ------- > > I've checked all the issues that have been reported, and they are all fixed. > > > Thanks, > > Mihaela Stoica > >
