Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/23#issuecomment-59347522
Mostly LGTM.
I found a pattern that all the baremetal changes are causing issues, from
the JIRA issue [1] this feature is in progress and I would only request
@frank-zhang to:
- Work in a separate feature branch and send a merge request when you think
this feature is ready
- Use better git commit messages as I'm unable to understand what Frank's
is trying to do, all commits have CLOUDSTACK-6278 as short message which does
not make sense to me
- Avoid hardcoding stuff in the source code and avoid check in to master
[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6278
Thanks and regards.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
