----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26871/#review57604 -----------------------------------------------------------
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh <https://reviews.apache.org/r/26871/#comment98389> Hari - I am not too familiar with the code so do educate me if I am wrong but as I have been asking repeated times why can we not make version mandatory rather than change this every release like you are doing right now ? - Nitin Mehta On Oct. 21, 2014, 6:09 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26871/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 6:09 a.m.) > > > Review request for cloudstack, Kishan Kavala and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7748 > https://issues.apache.org/jira/browse/CLOUDSTACK-7748 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-7748: Cloudstack version number is missing in system vm template. > /etc/cloudstack-release in system vm does not have version number which > leads in vm deployment failure while checking router version > > > During the system vm build, arguments can be passed to build.sh script > where 'version' argument is one of the optional arguments. The bug is even if > version argument is not passed defalut value(CLOUDSTACK_RELEASE=4.4.0) is > overridden by the null value (since argument is not passed). > > > Diffs > ----- > > tools/appliance/build.sh 8bf78b1 > tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh > c076bb5 > > Diff: https://reviews.apache.org/r/26871/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
