-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27878/
-----------------------------------------------------------

Review request for cloudstack, Brian Federle and Jessica Wang.


Bugs: CLOUDSTACK-7645
    https://issues.apache.org/jira/browse/CLOUDSTACK-7645


Repository: cloudstack-git


Description
-------

In some cases the UI does not display the correct text, displaying 'label.xyz' 
instead of the localized string.
This appears to be due to the dictionary split: entries in dictionary2.jsp are 
not found because the dictionary has not been extended with dictionary2 as 
expected.

In this fix:
- Instead of extending the dictionary, we leave it as it is and change the 
localization function to look in the dictionary first and, if the item is not 
found there, then look in dictionary2.
- This way we are not depending on the extent() function to be called at the 
'right' time; In turn, the localization function will be aware of both 
dictionaries.
- In the future, when we add another dictionary, we will have to modify this 
function only.


Diffs
-----

  ui/scripts/cloudStack.js c5aa89c 
  ui/scripts/sharedFunctions.js d463381 

Diff: https://reviews.apache.org/r/27878/diff/


Testing
-------


Thanks,

Mihaela Stoica

Reply via email to