----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28039/#review61707 -----------------------------------------------------------
Ship it! 5f99917991a59f8ecd6d8b0e17b497fe210e636e 4.5 and master - SrikanteswaraRao Talluri On Nov. 14, 2014, 2:34 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28039/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 2:34 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7912 > https://issues.apache.org/jira/browse/CLOUDSTACK-7912 > > > Repository: cloudstack-git > > > Description > ------- > > In many test cases, netscaler info is hard coded into test cases. Also they > are read from different sources, such as hardcoded config in test case and > test_data.py file. > > Ideally this information should be present in config file so that the marvin > code doesn't have to be changed while running test cases. We just should have > to make changes in config file. > > Additional changes: > 1. Pep8 fixes > 2. Import fixes > > > Important note: > > Following strucutre should be present in config file. If not present, the > test cases will be skipped. > > "netscalerDevice": { > "ipaddress": "x.x.x.x", > "username": "", > "password": "", > "networkdevicetype": "", > "publicinterface": "1/1", > "privateinterface": "1/1", > "numretries": 2, > "lbdevicededicated": "False", #(Or True) > "lbdevicecapacity": 2, > "port": 22 > } > > Values should be set according to netscaler device available. > > > Diffs > ----- > > test/integration/component/test_lb_secondary_ip.py daffe34 > test/integration/component/test_netscaler_lb.py 4c99aa3 > test/integration/component/test_netscaler_lb_algo.py 6eda9a3 > test/integration/component/test_netscaler_lb_sticky.py c333f60 > test/integration/component/test_persistent_networks.py 4cd0aa8 > tools/marvin/marvin/lib/common.py 9e3d40c > > Diff: https://reviews.apache.org/r/28039/diff/ > > > Testing > ------- > > Yes. > > Ran few test cases and result is as following: > > Test Create a "SourceBased" stick policy for a Lb rule with ... === TestName: > test_01_source_based_roundrobin | Status : SUCCESS === > ok > Test Create a "SourceBased" stick policy for a Lb rule ... === TestName: > test_02_source_based_source_algo | Status : SUCCESS === > ok > Test Create a "SourceBased" stick policy for a Lb rule with leastconn algo > ... === TestName: test_03_source_based_leastconn | Status : SUCCESS === > ok > Test Create a "LBCookie" stick policy for a Lb rule with roundrobin algo ... > === TestName: test_04_lbcookie_based_roundrobin | Status : SUCCESS === > ok > Test Create a "LBCookie" stick policy for a Lb rule with "Source" algorithm > ... === TestName: test_05_lbcookie_source_algo | Status : SUCCESS === > ok > Test Create a "LBCookie" stick policy for a Lb rule with leastconn algo ... > === TestName: test_06_lbcookie_leastconn | Status : SUCCESS === > ok > Test Create a "AppCookie" stick policy for a Lb rule with roundrobin algo ... > === TestName: test_07_appcookie_based_roundrobin | Status : SUCCESS === > ok > Test Create a "AppCookie" stick policy for a Lb rule with "Source" ... === > TestName: test_08_appcookie_source_algo | Status : SUCCESS === > ok > Test Create a "AppCookie" stick policy for a Lb rule with leastconn ... === > TestName: test_09_appcookie_leastconn | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 9 tests in 540.990s > > OK > > Test edit LB rule from least conn to round robin algo ... === TestName: > test_lb_least_conn_to_round_robin | Status : SUCCESS === > ok > === TestName: test_lb_least_conn_to_round_robin | Status : EXCEPTION === > ERROR > Test edit LB rule from round robin to source algo ... === TestName: > test_lb_leastconn_to_source | Status : SUCCESS === > ok > Test edit LB rule from round robin to least connection algo ... === TestName: > test_lb_round_robin_to_least_conn | Status : SUCCESS === > ok > Test edit LB rule from round robin to source algo ... === TestName: > test_lb_round_robin_to_source | Status : SUCCESS === > ok > Test edit LB rule from source to least conn algo ... === TestName: > test_lb_source_to_least_conn | Status : SUCCESS === > ok > Test edit LB rule from source to round robin algo ... === TestName: > test_lb_source_to_round_robin | Status : SUCCESS === > ok > Test Create LB rule with least connection algorithm ... === TestName: > test_lb_with_least_conn | Status : SUCCESS === > ok > Test Create LB rule with round robin algorithm ... === TestName: > test_lb_with_round_robin | Status : SUCCESS === > ok > > > Test Add multiple Vms to an existing LB rule. ... === TestName: > test_add_multiple_vms_lb | Status : SUCCESS === > ok > Test create LB rule with same public port after deleting rule ... === > TestName: test_01_create_with_same_public_port | Status : SUCCESS === > ok > Test Create LB rule for sourceNat IP address ... === TestName: > test_lb_on_ip_with_pf | Status : SUCCESS === > ok > > > Thanks, > > Gaurav Aradhye > >
