> On Nov. 19, 2014, 9:35 a.m., daan Hoogland wrote: > > the patch does not apply to 4.4, Can you have a look? > > daan Hoogland wrote: > I tried applying to 4.3 as well. it failed too
The error seems to be due to line endings in file. Existing file contains windows line endings while patch has unix line endings. It is applying cleanly with --ignore-whitespace option. git am --ignore-whitespace [patchfile] - Anshul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28213/#review62139 ----------------------------------------------------------- On Nov. 19, 2014, 5:17 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28213/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 5:17 a.m.) > > > Review request for cloudstack, daan Hoogland and Rajesh Battala. > > > Bugs: CLOUDSTACK-7752 > https://issues.apache.org/jira/browse/CLOUDSTACK-7752 > > > Repository: cloudstack-git > > > Description > ------- > > Fixed deployment planner stuck in infinite loop. If we create VM with shared > service offering and attach disk with local disk offering, and one of storage > pool is full(cannot be allocated) and other is not full then we are not > putting the cluster in avoid list which is causing this infinite loop. > > Fixed by putting the cluster in avoid list even if one of the storage pool is > full(cannot be allocated) > > > Diffs > ----- > > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java > d9e1ecc2291a72a04ee0c1b35a079d5ff166bf77 > > Diff: https://reviews.apache.org/r/28213/diff/ > > > Testing > ------- > > > Thanks, > > Anshul Gangwar > >
