----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28390/#review62971 -----------------------------------------------------------
Ship it! 2805f51e433d4005469c656ed03854a83028637b 4.5 4f825288290cc7ec67301a3aa1306d30eb1e682b master - SrikanteswaraRao Talluri On Nov. 24, 2014, 10:58 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28390/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 10:58 a.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7965 > https://issues.apache.org/jira/browse/CLOUDSTACK-7965 > > > Repository: cloudstack-git > > > Description > ------- > > Fixing a test script issue. > > When forceful domain deletion fails, code in except adds the child accounts > in cleanup list. But they might have deleted during the domain deletion > operation. In that case the cleanup operation fails. > > Domain deletion should be outside the try catch block. > > > Diffs > ----- > > test/integration/component/test_persistent_networks.py f782700 > > Diff: https://reviews.apache.org/r/28390/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >