----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28437/#review62993 -----------------------------------------------------------
test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105166> We have simple assert available through self.assert, can we use that, to keep uniform notation across all other places? test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105164> Description does not seem to represent test case name test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105163> Is aclgroup None a failure or not None a failure? test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105165> why not simple len(aclList) instead of aclList.__len__()? test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105162> There are no steps for this test case test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105157> This is not clear, is it that we are expecting it to be None and if not None fail the test case? test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105160> Please provide a valid name instead of network_created to some meaningful. test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105161> This network creation is not available in steps for the test test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105158> try adding the element vpc right after creation. If test case fails for some reason between vpc creation and network creation step, then say vpc created still remain as it is and will effect other steps. test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/28437/#comment105159> Why two asserts for same element "network_created" - Santhosh Edukulla On Nov. 25, 2014, 10:24 a.m., anusha bilgi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28437/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 10:24 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: cloudstack-6282 > https://issues.apache.org/jira/browse/cloudstack-6282 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6282 Added automated ACL tests > > > Diffs > ----- > > test/integration/component/test_escalations_networks.py fb2196c > > Diff: https://reviews.apache.org/r/28437/diff/ > > > Testing > ------- > > Tests the changed files and attached are the results for the same > > > File Attachments > ---------------- > > results.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt > > > Thanks, > > anusha bilgi > >
