----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27611/#review62996 -----------------------------------------------------------
test/integration/component/test_escalations_ipaddresses.py <https://reviews.apache.org/r/27611/#comment105167> We dont need this check, validateList already has taken care of this. test/integration/component/test_escalations_ipaddresses.py <https://reviews.apache.org/r/27611/#comment105171> Why list again, may be we want to list once and verify the required cases all once post the list? test/integration/component/test_escalations_ipaddresses.py <https://reviews.apache.org/r/27611/#comment105172> We dont need this length validation again test/integration/component/test_escalations_ipaddresses.py <https://reviews.apache.org/r/27611/#comment105170> Too much of repetetive code here i believe, why not list all publicipaddress and then check for required conditions? May be it will reduce the number of lines here. test/integration/component/test_escalations_ipaddresses.py <https://reviews.apache.org/r/27611/#comment105174> Is clean up required for self.account? test/integration/component/test_escalations_isos.py <https://reviews.apache.org/r/27611/#comment105175> Is the comment right? test/integration/component/test_escalations_networks.py <https://reviews.apache.org/r/27611/#comment105176> This is not required. test/integration/component/test_escalations_volumes.py <https://reviews.apache.org/r/27611/#comment105179> Why do we need to assert here? test/integration/component/test_escalations_vpncustomergateways.py <https://reviews.apache.org/r/27611/#comment105177> We dont need this i believe test/integration/component/test_escalations_vpncustomergateways.py <https://reviews.apache.org/r/27611/#comment105178> I believe the message sould be not matching by name - Santhosh Edukulla On Nov. 5, 2014, 10:40 a.m., Avinash Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27611/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 10:40 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6282 > https://issues.apache.org/jira/browse/CLOUDSTACK-6282 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6282 - Added automated tests for filter feature > > > Diffs > ----- > > test/integration/component/test_escalations_ipaddresses.py 41e5b2f > test/integration/component/test_escalations_isos.py 4e818a5 > test/integration/component/test_escalations_networks.py fb2196c > test/integration/component/test_escalations_securitygroups.py ffaf657 > test/integration/component/test_escalations_snapshots.py 4b6b7f5 > test/integration/component/test_escalations_templates.py 3dc24c1 > test/integration/component/test_escalations_volumes.py 7290325 > test/integration/component/test_escalations_vpncustomergateways.py b09930a > > Diff: https://reviews.apache.org/r/27611/diff/ > > > Testing > ------- > > Tested all the files to which tests are added and atatched are the result > files > > > File Attachments > ---------------- > > IPAddressresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt > ISOresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt > Networksresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt > SecurityGroupsresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt > Snapshotresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt > Templatesresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt > Volumeresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt > VPNCustomerGatewaysresults.txt > > https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt > > > Thanks, > > Avinash Gautam > >
