----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28535/#review63285 -----------------------------------------------------------
core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java <https://reviews.apache.org/r/28535/#comment105443> If you want insertion ordered iteration or array (toArrary output) why not use LinkedHashSet? Even if TreeSet will return sorted/ordered traversal or array, it will add log(n) complexity to already O(n) loop. Should we use that and fix any tests accordingly? Can you also share the test and log which broke for you? - Rohit Yadav On Nov. 29, 2014, 9:22 a.m., tian chunfeng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28535/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2014, 9:22 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > run test on core failed : Change firewall rule set from HashSet to TreeSet > because HashSet elements are not ordered , which will cause test failed when > elements toArray are not same between windows and mac . > > > Diffs > ----- > > core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java be85887 > > Diff: https://reviews.apache.org/r/28535/diff/ > > > Testing > ------- > > after ensure the firewall rule set in TreeSet , toArray will the same order > accross windows and mac platform, and passed test. > > > Thanks, > > tian chunfeng > >
