> On déc. 5, 2014, 5:55 après-midi, Rohit Yadav wrote: > > Interesting feature, can you send another patch that applies cleanly on > > master? I'll add known UI contributors who may help review your patch. > > Axel Delahaye wrote: > I have the new diff but I can't upload it for J.F. Vincent > > Rohit Yadav wrote: > Send it separetely, Github PR on github.com/apache/cloudstack (Github is > more fun that ReviewBoard), I see you both have atos.net in email (assuming > you're both colleagues). > Once we've that PR we can close this review request.
done, PR #55 - Axel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19995/#review64022 ----------------------------------------------------------- On déc. 5, 2014, 5:56 après-midi, Jean-Francois Vincent wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19995/ > ----------------------------------------------------------- > > (Updated déc. 5, 2014, 5:56 après-midi) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Repository: cloudstack-git > > > Description > ------- > > VM creation user interface : added the Userdata field > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties 8abe874 > ui/index.jsp 4910b9f > ui/scripts/instanceWizard.js c2d3030 > > Diff: https://reviews.apache.org/r/19995/diff/ > > > Testing > ------- > > tested done on 4.2.1. This patch was adapted for last master branch. > > > Thanks, > > Jean-Francois Vincent > >
