----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71192 -----------------------------------------------------------
test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116866> variable ... usagefortemplatefromvolume instead of usageforvolumefromtemplate test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116867> dint get the need or use of this validation ... test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116868> i think just checking snapshot in description is a loose check we should check based on volume id test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116869> the check should only check for equality test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116870> i dont think these two fileds templtat.id and record.usageid are same test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116871> check only for equality test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116872> change message to reflect usage for snamshot test/integration/testpaths/testpath_usage.py <https://reviews.apache.org/r/28030/#comment116873> we can find acurate timing as well .so better check than just checking >0 - shweta agarwal On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28030/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 12:24 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7911 > https://issues.apache.org/jira/browse/CLOUDSTACK-7911 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for Usage test path. More test cases to follow. This is > first patch. > > > Diffs > ----- > > test/integration/testpaths/testpath_usage.py PRE-CREATION > tools/marvin/marvin/config/test_data.py d5ed353 > tools/marvin/marvin/dbConnection.py 66c6cb1 > tools/marvin/marvin/lib/base.py e38c394 > tools/marvin/marvin/lib/utils.py 8788b3b > > Diff: https://reviews.apache.org/r/28030/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
