----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30658/#review72340 -----------------------------------------------------------
Ship it! 015aed9befcd4f433bebe2f01135456b9688f3c9 master - SrikanteswaraRao Talluri On Feb. 5, 2015, 10:26 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30658/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 10:26 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8217 > https://issues.apache.org/jira/browse/CLOUDSTACK-8217 > > > Repository: cloudstack-git > > > Description > ------- > > The code in marvin base library passes the lbdevicecapcity parameter while > adding netscaler device only if the key "lbdevicededicated" is not present in > services dict, which is wrong. > > The value of lbdevicecapacity should be passed to API irrespective of > "lbdevicededicated" key and its value. > > > Diffs > ----- > > tools/marvin/marvin/lib/base.py e38c394 > > Diff: https://reviews.apache.org/r/30658/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Gaurav Aradhye > >
