----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31078/#review72701 -----------------------------------------------------------
Ship it! a95ce8138adc8b0f51e90d6e4c5487d48be81085 master - SrikanteswaraRao Talluri On Feb. 16, 2015, 7:53 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31078/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 7:53 a.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8257 > https://issues.apache.org/jira/browse/CLOUDSTACK-8257 > > > Repository: cloudstack-git > > > Description > ------- > > Test_escalations_volume.py has two test cases which assert the created volume > name with the name passed through test data. However this won't hold true > when random characters are appended to the volume before its creation. > > There is no need of such assert as we are already checking the API response > is not None. > > Removed the unnecessary asserts. > > > Diffs > ----- > > test/integration/component/test_escalations_volumes.py d650121 > > Diff: https://reviews.apache.org/r/31078/diff/ > > > Testing > ------- > > Did not run these. Should run fine. > > > Thanks, > > Gaurav Aradhye > >
