Thanks for clarification, Erik. So using custom db names should be avoided as much as possible.
Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro ----- Original Message ----- > From: "Erik Weber" <terbol...@gmail.com> > To: "dev" <dev@cloudstack.apache.org> > Sent: Friday, 27 February, 2015 09:22:40 > Subject: Re: [GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute > schema refe... > On Fri, Feb 27, 2015 at 10:15 AM, Nux! <n...@li.nux.ro> wrote: > >> Hi, >> >> "Hardcoding" the name is not a very good idea, I understand that under the >> circumstances is OK, but still. >> >> We have to be aware of this detail as there could be people using another >> name for their DB (I did this in the past). Would upgrades fail for them >> now? >> >> This should be mentioned in the release notes. >> >> > Everything in the file is hardcoded > This change just changed two references who weren't previously hardcoded > and would fail in newer mysql versions. > > The better way would be to get the database names from some form of input > and default to cloud / cloud_usage, but I reckon there's a hell of a lot of > places that would need that change. > > -- > Erik
