Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/commit/8e953fe8593cf624c37213d94f79ea9e17a12f27#commitcomment-10121450
In systemvm/patches/debian/config/opt/cloud/bin/savepassword.sh:
In systemvm/patches/debian/config/opt/cloud/bin/savepassword.sh on line 33:
* The intention is not clear here to me. Should the value be `true` if cat
fails?
* Recommending to add quotes.
~~~bash
TOKEN=""
if [ -r /tmp/passwdsrvrtoken ]; then
TOKEN="$(cat /tmp/passwdsrvrtoken)"
fi
~~~
or
~~~bash
TOKEN=true
if [ -r /tmp/passwdsrvrtoken ]; then
TOKEN="$(cat /tmp/passwdsrvrtoken)"
fi
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
