----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32094/#review76540 -----------------------------------------------------------
test/integration/component/test_escalations_instances.py <https://reviews.apache.org/r/32094/#comment124110> Please keep specific imports rather than import * test/integration/component/test_escalations_instances.py <https://reviews.apache.org/r/32094/#comment124111> Not sure if we running/skipping tests on specific hypervisor depending uppon tags. Can you add a condition in the test case? test/integration/component/test_escalations_instances.py <https://reviews.apache.org/r/32094/#comment124113> Please remove pep8 issues test/integration/component/test_escalations_instances.py <https://reviews.apache.org/r/32094/#comment124112> Please use validateList method fomr utils.py test/integration/component/test_escalations_instances.py <https://reviews.apache.org/r/32094/#comment124115> Please read host credentails from configurableData section in test_data.py file test/integration/component/test_escalations_instances.py <https://reviews.apache.org/r/32094/#comment124116> No need to sleep as the check is included in base library, check VirtualMachine.start() function tools/marvin/marvin/config/test_data.py <https://reviews.apache.org/r/32094/#comment124117> Will this work on automated builds? tools/marvin/marvin/config/test_data.py <https://reviews.apache.org/r/32094/#comment124118> Unwanted change? - Gaurav Aradhye On March 16, 2015, 2:53 p.m., shweta agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32094/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 2:53 p.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > ------- > > test case added to verify restore VM operation > > > Diffs > ----- > > test/integration/component/test_escalations_instances.py 4b22016 > tools/marvin/marvin/config/test_data.py 80ead64 > > Diff: https://reviews.apache.org/r/32094/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > shweta agarwal > >
