GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/138
CLOUDSTACK-8356: Mentioning netaddr module in setup.py in marvin as it is used across test cases The netaddr module is used in various test cases but it is not mentioned in setup.py file. Test cases will fail with import error if the module is absent on user machine even when marvin is installed. Mentioning the netaddr module in setup.py file so it is installed with marvin. Tested the change with packaging new marvin tar with the change and installing marvin with pip on a machine which did not have netaddr module. It downloaded and installed it automatically. pip install Marvin-4.5.1.0.tar.gz Unpacking ./Marvin-4.5.1.0.tar.gz Running setup.py (path:/tmp/pip-D49qWR-build/setup.py) egg_info for package from file:///root/Marvin-4.5.1.0/dist/Marvin-4.5.1.0.tar.gz warning: no files found matching '*.txt' under directory 'docs' Requirement already satisfied (use --upgrade to upgrade): mysql-connector-python>=1.1.6 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0) Requirement already satisfied (use --upgrade to upgrade): requests>=2.2.1 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0) Requirement already satisfied (use --upgrade to upgrade): paramiko>=1.13.0 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0) Requirement already satisfied (use --upgrade to upgrade): nose>=1.3.3 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0) Requirement already satisfied (use --upgrade to upgrade): ddt>=0.4.0 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0) Downloading/unpacking netaddr>=0.7.11 (from Marvin==4.5.1.0) Downloading netaddr-0.7.14-py2.py3-none-any.whl (1.5MB): 1.5MB downloaded Installing collected packages: netaddr, Marvin Found existing installation: Marvin 0.1.0 Uninstalling Marvin: Successfully uninstalled Marvin Running setup.py install for Marvin warning: no files found matching '*.txt' under directory 'docs' Installing marvincli script to /usr/bin Successfully installed netaddr Marvin Cleaning up... You can merge this pull request into a Git repository by running: $ git pull https://github.com/gauravaradhye/cloudstack 8356 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #138 ---- commit 692a56e86803ef8b8bcb20c37764a31da091f510 Author: Gaurav Aradhye <gaurav.arad...@clogeny.com> Date: 2015-04-01T07:09:47Z CLOUDSTACK-8356: Mentioning netaddr module in setup.py in marvin as it is used across test cases ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---