Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/222#issuecomment-98372263
  
    I thought the intent of introducing 'Unkonwn' host status was to replace 
the entire null semantics that was thought to be confusing in the 
investigators. By doing it partially aren't we introducing more confusion - now 
there is 'null' as well as 'Unknown' semantics.
    
    Also specific to the change I see the below code removed
    if (vmState == null) {continue;}
    
    Shouldn't it be 
    if (vmState == Status.Unknown) {continue;}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to