Github user K0zka commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/238#discussion_r30176487
  
    --- Diff: ui/index.jsp ---
    @@ -1761,73 +1761,73 @@
             <!-- jquery.tokeninput.js -->
             <script src="lib/jquery.tokeninput.js" 
type="text/javascript"></script>
             <!-- CloudStack -->
    -        <script type="text/javascript" 
src="scripts/ui/core.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/utils.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/events.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/dialog.js?t=<%=now%>"></script>
    -
    -        <script type="text/javascript" 
src="scripts/ui/widgets/multiEdit.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/overlay.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/dataTable.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/cloudBrowser.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/listView.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/detailView.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/treeView.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/notifications.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/tagger.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui/widgets/toolTip.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/cloud.core.callbacks.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/sharedFunctions.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/login.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/projects.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/cloudStack.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/lbStickyPolicy.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/autoscaler.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/healthCheck.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/autoscaler.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/granularSettings.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/zoneChart.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/dashboard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/installWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/installWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/projects.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/dashboard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/instanceWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/instanceWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/affinity.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/affinity.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/instances.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/events.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/regions.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/regions.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/ipRules.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/enableStaticNAT.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/securityRules.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/vpc.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/vpc.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/network.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/recurringSnapshots.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/uploadVolume.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/storage.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/templates.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/accountsWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/accountsWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/accounts.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/configuration.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/globalSettings.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/zoneWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/physicalResources.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/ui-custom/zoneWizard.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/system.js?t=<%=now%>"></script>
    -        <script type="text/javascript" 
src="scripts/domains.js?t=<%=now%>"></script>
    --- End diff --
    
    I have no IE righ here, but the 'never' setting seems to be a problem. I 
would love to see it going away but if that creates bugreports or confusion for 
users then it is no fun. Would you agree in having that 'now' thing only for IE 
for safety?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to