GitHub user ntavares opened a pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/6
2 more fixes
2 more fixes... I ended up deleting the branch and restarting. The other
git log was cluttered with back-and-forth tries to fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ntavares/cloudstack-cloudmonkey master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack-cloudmonkey/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit 293b730cf30a84a3f40edddd2a3a53ce7ec8a0a5
Author: Nuno Tavares <[email protected]>
Date: 2015-05-22T14:00:43Z
FIX split for paramter=value where value could be anything. An example case
where value can contain the "=" sign: registerSSHKeyPair (publickey)
commit 9448a03ec7dbe429bfba7a95d95052870201f498
Author: Nuno Tavares <[email protected]>
Date: 2015-05-22T14:01:48Z
FIX some parameters are double encoded (UI uses javascript to encode on the
fly, see ui/scripts/accounts.js:1852), such as registerSSHKeyPair/publickey. I
did a quick search for other cases, bu there may be more parameters.
commit c95f01f20060d77a1d043a0dce8b6bec1ae4eef2
Author: Nuno Tavares <[email protected]>
Date: 2015-05-22T14:05:07Z
Provide signatureversion as config.option for backward compatibility;
Follow specification: only provide signatureversion=&expires= in URL if
signatureversion=3
http://docs.cloudstack.apache.org/en/latest/dev.html?highlight=signatureversion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
