Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105173698
I'm focussing on getting this sorted out so we can merge.
@mlsorensen I like the idea of not changing anything in case the username
is 'root'.
Did some reading on 'require tty' security implications and I'm quite sure
it doesn't matter much in our case. We could as well just document it then.
To wrap it up:
- Let's make sure sudo is NOT prepended when the username equals 'root'.
This way we ensure the current behaviour is unchanged and does not require sudo
- Since we require a sudo config anyway, let's document it properly. The
minimal version I tested (assuming a non-privileged user cloudstack, can be any
user):
```
cloudstack ALL=NOPASSWD: /usr/bin/cloudstack-setup-agent
defaults:cloudstack !requiretty
```
This removes the 'requiretty' only for the cloudstack user so it does not
change anything for existing sudo configs. Once we agree, I'll take care of
documenting it.
@bhaisaab Could you implement sudo only if non-root user please? This would
then be the only improvement before we can merge this PR. Let me know if I can
help other than testing it again.
Do we all agree this is a great step we can take now?
Apart from this we can discuss other improvements. I just don't want that
to stop this small improvement with great value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
