GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/317
Fix/citrix resource base packages
Hi @DaanHoogland and @bhaisaab
I have fixed the packaging under the test directory.
All the tests classes had the package declaration pointing to a location
that did not exist. For Maven it was fine, because it used a --sourcepath
during build. However, when using an IDE it was complaining. Despite the IDE
fact, it's not nice to have differences between source directory and package
declaration.
In addition, I also renamed the package from
"com.cloud.hypervisor.xenserver.resource.wrapper.citrix" to
"com.cloud.hypervisor.xenserver.resource.wrapper.xenbase"
Usual tests have been executed with the following environment:
XenServer 6.2
Tiny Linux VHD (people.apache.org/~bhaisaab/vms/)
MySQL/MariaDB 5.5.41
Management Server running CentOS 7
Component/Smoke tests: https://github.com/apache/cloudstack
(test/integration/component and smoke)
Storage type: NFS shared
Isolation method: VLAN
Cheers,
Wilder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack
fix/citrix_res_base_packages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #317
----
commit 9410fbf948646a57fe0125f712b63502c2433614
Author: wilderrodrigues <[email protected]>
Date: 2015-05-26T08:43:38Z
Fixing the packaging of the Xen resource tests
- The package declaration of all Test classes was point to a package that
was not represented as a directory
- For example: Class A had "package b.c.d;" as declaration, but the class
A was under directory "c"
Maven was bulding the project and executing the tests just fine because it
uses "-sourcepath". However,
with IDEs and javac it would fail.
commit 1f4a460593b36e45befc8dfad53698ab9ea48b5d
Author: wilderrodrigues <[email protected]>
Date: 2015-05-26T08:43:38Z
Fixing the packaging of the Xen resource tests
- The package declaration of all Test classes was point to a package that
was not represented as a directory
- For example: Class A had "package b.c.d;" as declaration, but the class
A was under directory "c"
Maven was bulding the project and executing the tests just fine because it
uses "-sourcepath". However,
with IDEs and javac it would fail.
commit a27129d0db344710e56d26e01a2cb71c957e8a8d
Author: wilderrodrigues <[email protected]>
Date: 2015-05-27T08:15:22Z
Merge remote-tracking branch 'origin/fix/citrix_res_base_packages' into
fix/citrix_res_base_packages
Rebasing branch with latest master
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
