GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/364
Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int) This now correctly compares strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/364.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #364 ---- commit 5a3e3ff57f87dde0ec5c87fba0ebf3649aafe527 Author: Rafael da Fonseca <rsafons...@gmail.com> Date: 2015-06-07T19:18:11Z Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int) This now correctly compares strings ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---