Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/460#discussion_r32469324
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,7 @@ public Answer forgetObject(ForgetObjectCmd cmd) {
}
private static String deriveTemplateUuidOnHost(VmwareHypervisorHost
hyperHost, String storeIdentifier, String templateName) {
- String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" +
storeIdentifier + "-" + hyperHost.getMor().getValue()).getBytes()).toString();
+ String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" +
storeIdentifier + "-" +
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
--- End diff --
Unless you're getting platform specifc data, i think it's best to always
stick to use the same charset, to avoid different values from being generated
in different platforms whenever possible. Ideally, we should convert all data
that comes into the application to a standard charset that supports
internationalization such as UTF-8, and just use default platform charset where
applicable, when consuming data from platform specific sources.
Using Charset.defaultCharset() will require an extra import and increase
the overall size of the class, altough instantiating a String also has its own
overhead, i believe it to be less so.. we can also remove string instantiation
at runtime by defining a constant, which will also increase runtime efficiency.
Of course this is only my point of view, please comment if you feel
otherwise :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
