Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/541#issuecomment-117541379
Hi @likitha
And what about DeleteVolume? It now supports only VMware, but the
MigrateVolume supports both VMware and HyperV. It would be nice to keep it
consistent.
I have 2 suggestions:
1. Edit the issue title to make sure that it complies with your fix.
Something like this: Failed to migrate a volume from zone-wide to cluster-wide
storage when using VMware.
2. If you don't mind, create another issue to deal with the
StorageAction.DELETEVOLUME and change it in a separate PR. I think it should be
consistent.
You got my LGTM based on the explanations you gave.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
