Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/560#issuecomment-118787549
Hi @rafaelweingartner
The XenServer plugin build failed:
I'm trying to find out why it did so.
A way to move forward would be for me, or someone else, to try to test your
PR. I'm busy with another PR now, but if nobody picks your change, I might have
a look later today.
Concerning your comments about XcpServerNetworkUsageCommandWrapper and
XenServer56NetworkUsageCommandWrapper being almost the same, that's due to the
refactor I did on the CitrixResourceBase class. The refactor looked only at
change the structure of the code, not behaviour. If 2 wrappers look/are the
same, we need to do further work. I will take some time to look into it as well.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
