LGTM On Wed, Jul 15, 2015 at 3:29 PM, pritisarap12 <g...@git.apache.org> wrote:
> GitHub user pritisarap12 opened a pull request: > > https://github.com/apache/cloudstack/pull/594 > > CLOUDSTACK-8637: Verify that VM with same Display name creation fails > if vm.instancename.flag=true > > When vm.instancename.flag=true it will only set the "instancename" > without any additional prefix so name of the instance on host will also be > same hence verify that when tried to create another instance with same name > on same host should fail on VMWare as it should have every instance with > unique name. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/pritisarap12/cloudstack > CLOUDSTACK-8637-Verify-that-cloudstack-gives-error-on-creation-of-VMs-with-the-same-Display-name-when-vm.instancename.flag=true > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/cloudstack/pull/594.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #594 > > ---- > commit a2df28d2f7f2596a121a53ee064250b62bb3b6c2 > Author: Priti Sarap <priti.sa...@clogeny.com> > Date: 2015-07-15T09:46:24Z > > CLOUDSTACK-8637: Verify that VM with same Display name creation fails > if vm.instancename.flag=true > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
