Can somebody please review this PR? On Tue, Jul 14, 2015 at 5:58 PM, sanju1010 <g...@git.apache.org> wrote:
> GitHub user sanju1010 opened a pull request: > > https://github.com/apache/cloudstack/pull/586 > > CLOUDSTACK-8634: Made changes to test_security_group.py test suite to > support EIP > > > Made changes to test_security_group.py test suite to support EIP > > 1. In case of a basic zone with EIP/ELB capability vm will have two ip > addresses one from public ip range and another one from guest ip range. > vm creation method in base.py returns vm ip address which is part of > guest ip range as the vm.ssh.ipaddress if we don't pass mode to it. So > access to vms with that ip address would not be successful. Made changes to > handle this > 2.vm public address is associated with Netscaler. So even if we don't > allow ping traffic in security groups applied to vm, ping will be > successful. Skipping ping test in case the zone is enabled with EIP/ELB > 3.Removing default rules from security groups except what is needed > for that test. > > > Test Results: > ========== > Test ingress rules for specific IP set ... === TestName: > test_ingress_rules_specific_IP_set | Status : SUCCESS === > ok > Test revoke ingress rule ... === TestName: test_01_revokeIngressRule | > Status : SUCCESS === > ok > Test ingress rules for specific IP set and non default security group > ... === TestName: test_ingress_rules_specific_IP_set_non_def_sec_group | > Status : SUCCESS === > ok > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/sanju1010/cloudstack eip > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/cloudstack/pull/586.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #586 > > ---- > commit 3ecf3dc172cc5f60f55d9b389d3e53a6a1e67f05 > Author: sanjeev <sanj...@apache.org> > Date: 2015-07-14T11:54:58Z > > CLOUDSTACK-8634: Made changes to test_security_group.py test suite to > support EIP > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
