[GitHub] cloudstack pull request: Dereference NULL return value

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/618#discussion_r35521326
  
    --- Diff: 
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
 ---
    @@ -119,12 +123,12 @@
         @Override
         public boolean start() {
             if (isSAMLPluginEnabled()) {
    -            setup();
                 s_logger.info("SAML auth plugin loaded");
    +            return setup();
             } else {
    --- End diff --
    
    we can remove else {} here just keep;
    if (condition){
    return stuff();
    }
    return otherstuff();


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---