Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/625#discussion_r35532842
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
       CONSTRAINT `fk_external_bigswitch_bcf_devices__host_id` FOREIGN KEY 
(`host_id`) REFERENCES `host`(`id`) ON DELETE CASCADE,
       CONSTRAINT `fk_external_bigswitch_bcf_devices__physical_network_id` 
FOREIGN KEY (`physical_network_id`) REFERENCES `physical_network`(`id`) ON 
DELETE CASCADE
     ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
    +
    +INSERT IGNORE INTO `cloud`.`configuration` VALUES ("Advanced", 'DEFAULT', 
'management-server', "usage.report.interval", 7, "Interval (days) between 
sending anonymous Usage Reports back to the CloudStack project", "", NULL, 
NULL, 0);
    --- End diff --
    
    with the new style config (ConfigKey<T>), this isn't needed is it? It 
should insert the default if it doesn't find the value. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to