Github user devdeep commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/635#discussion_r35849928
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
 ---
    @@ -60,6 +61,15 @@
                    description = "template ID of the template to be prepared 
in primary storage(s).")
         private Long templateId;
     
    +    @ACL(accessType = AccessType.OperateEntry)
    +    @Parameter(name = ApiConstants.STORAGE_ID,
    +            type = CommandType.UUID,
    +            entityType = StoragePoolResponse.class,
    +            required = false,
    +            description = "storage pool ID of the primary storage pool to 
which the template should be prepared. If it is not provided the template" +
    +                    " is prepared on all the available primary storage 
pools.")
    +    private Long storageId;
    --- End diff --
    
    @kishankavala There isn't a poolid or storagePoolid constant available in 
apiconstants. I had looked for it and couldn't find it. Moreover, storageId is 
the parameter name used through the apis whenever a primary storage pool is 
referred, for example in list/update/migrate volumes, volume response etc. So I 
decided to use storageId here too for consistency, instead of defining a new 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to