GitHub user ntavares opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/8
FIX responses /contain/ word "response", but may not exactly match Hi @bhaisaab , commit 242b8e7ed3688ca137b7879da6c3a5774deeda06 introduced a problem.. AFAICS, not all responses have the key 'response', but rather they might have a key with "response" string in the name, so this check will cause the response to be dumped with an error message. All calls now are returning "Error Invalid response received" - luckily only the async block follows, so the command gets executed anyway. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ntavares/cloudstack-cloudmonkey master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-cloudmonkey/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 ---- commit 293b730cf30a84a3f40edddd2a3a53ce7ec8a0a5 Author: Nuno Tavares <n.tava...@tech.leaseweb.com> Date: 2015-05-22T14:00:43Z FIX split for paramter=value where value could be anything. An example case where value can contain the "=" sign: registerSSHKeyPair (publickey) commit 9448a03ec7dbe429bfba7a95d95052870201f498 Author: Nuno Tavares <n.tava...@tech.leaseweb.com> Date: 2015-05-22T14:01:48Z FIX some parameters are double encoded (UI uses javascript to encode on the fly, see ui/scripts/accounts.js:1852), such as registerSSHKeyPair/publickey. I did a quick search for other cases, bu there may be more parameters. commit c95f01f20060d77a1d043a0dce8b6bec1ae4eef2 Author: Nuno Tavares <n.tava...@tech.leaseweb.com> Date: 2015-05-22T14:05:07Z Provide signatureversion as config.option for backward compatibility; Follow specification: only provide signatureversion=&expires= in URL if signatureversion=3 http://docs.cloudstack.apache.org/en/latest/dev.html?highlight=signatureversion commit f1bd8be78dc70ad8c9d52c434b1f2f773fd4f018 Author: Nuno Tavares <n.tava...@tech.leaseweb.com> Date: 2015-06-12T09:24:21Z sync with upstream/master commit 598bc3a533dbdbf5372cf59203ae10a36abc4d87 Author: Nuno Tavares <n.tava...@tech.leaseweb.com> Date: 2015-07-24T08:00:07Z Merge branch 'master' of github.com:apache/cloudstack-cloudmonkey commit b765bbd17e293c0c2e49ce9529ba3dd43d2d500f Author: Nuno Tavares <n.tava...@tech.leaseweb.com> Date: 2015-08-03T09:06:23Z FIX responses /contain/ word "response", but may not exactly match ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---