Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129398162
Looks Good to me.
Probably remove_nic might return an error if the NIC is not removed , but
just wondering if a check is needed in the below step , to validate that only 1
NIC exists for the VM by listing nics after the remove nic operation? If you
feel the check is redundant then leave it.:
#Try to remove nic 2 from vm1
+ try:
+ vm1.remove_nic(self.apiclient, self.nics[0].id)
+ except Exception as e:
+ self.fail("Failed to delete the nic from vm")
+ return
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
