Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/680#discussion_r36865162
  
    --- Diff: ui/scripts/instances.js ---
    @@ -618,11 +618,11 @@
                             createForm: {
                                 title: 'label.action.destroy.instance',
                                 desc: 'label.action.destroy.instance',
    -                isWarning: true,
    +                            isWarning: true,
                                 preFilter: function(args) {
    -                                if (isAdmin() || isDomainAdmin()) {
    -                                    
args.$form.find('.form-item[rel=expunge]').css('display', 'inline-block');
    -                                } else {
    +                                // Hide the expunge checkbox when the 
authenticated user
    +                                // can't expunge VMs. Related to 
CLOUDSTACK-8580.
    --- End diff --
    
    I think the var name is explanatory. the comment could go with allocation 
and not use of the thingy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to