Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/351#discussion_r37174039
  
    --- Diff: 
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
    @@ -2294,7 +2292,7 @@ private void orchestrateMigrateWithStorage(final 
String vmUuid, final long srcHo
                     s_logger.info("Migration was unsuccessful.  Cleaning up: " 
+ vm);
                     _alertMgr.sendAlert(alertType, srcHost.getDataCenterId(), 
srcHost.getPodId(),
                             "Unable to migrate vm " + vm.getInstanceName() + " 
from host " + srcHost.getName() + " in zone " + dc.getName() + " and pod " + 
dc.getName(),
    -                        "Migrate Command failed.  Please check logs.");
    +                        "Migrate Command failed. HA may not work for 
Hyper-V VM.  Please check logs.");
    --- End diff --
    
    A hypervisor specific message in a generic module can lead to confusion. I 
would like to see the Hyper-V text replaced by a reference to hypervisortype or 
replaced by something more generic altogether


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to