Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/673#discussion_r37181982
--- Diff:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ---
@@ -136,13 +136,13 @@ public String getInstanceName() {
return instanceName;
}
- public Map getDetails() {
+ public Map<String, String> getDetails() {
--- End diff --
how about taking the opportunity to change this to
public Map<String, String> getDetails() {
if (this.details == null || this.details.isEmpty()) {
return null;
}
return details;
}
Is there any reason to pass through the crazy construct of getting the
pointer to the first element and casting it back to a map? It seems like very
unsafe. It becomes even more unsafe when using an instance of a generic type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
