Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/727#discussion_r37721518
  
    --- Diff: test/integration/smoke/test_iso.py ---
    @@ -600,6 +603,6 @@ def test_07_list_default_iso(self):
             # list ISO should list default ISOS (VM and xen tools)
     
             # ListIsos to list default ISOS (VM and xen tools)
    -        self.get_iso_details("xs-tools.iso")
             self.get_iso_details("vmware-tools.iso")
    +        self.get_iso_details("xs-tools.iso")
    --- End diff --
    
    This is a good use case for using map instead of calling the 
get_iso_details twice. Otherwise LGTM !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to