Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134875242
HI @koushik-das
I've reviewed the code in this PR and it looks pretty good. I really like
what might seem like small things (lower-case on method names, extra spaces in
log messages, etc). It shows attention to detail. Kudos for that.
I would like to run this somehow. Can you give me some pointers to how can
I do that?
I mean, I get I need to run the simulator (although I never have before, I
will learn), but then what about data center config to be deployed?
I assume that the test `smoke/test_scale_vm.py` will be the one to hit this
code.
Also, if I can suggest an improvement, I would make the commit message (and
the PR title along with it) more concrete. I mean, you do specify three changes
in the body of the message, but the header is what we typically read in the
commit history. I would re-write it as (your second bullet point): "Added
support for scaling up a running VM in simulator". It seems to me like the best
balance between explaining the intention of the change and not adding too much
low-level details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
