Github user michaelandersen commented on the pull request:

    https://github.com/apache/cloudstack/pull/692#issuecomment-134932710
  
    verified that conntrackd starts on redundant vpc routers. 
    LGTM in that respect.
    
    Design wise i feel we need to refactor this, naming of copy_if_needed is 
ambiguous. 
    Also we're running a lot of boilerplate code which can be replaced by more 
widely used and maintained python packages. 
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to