GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/751

    CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/temp…

    …late listing
    
    Due to aggregation of templates and isos on the UI/client side, it could 
result
    that for each page we could end up having lesser templates/isos listed to 
have
    the scroll shown that triggers infinite scrolling. The fix is to use similar
    approach as in projects.js, to use the maximum pagesize of 500. In theory, 
there
    is still a chance if there are 500 zones with the same template being listed
    resulting in only one aggregated template which could cause the scroll to 
not
    get shown; but in practice I believe this fix should work for most users.
    
    (cherry picked from commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd)
    Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack master-CLOUDSTACK-8766

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #751
    
----
commit 9fe2404d83035ee3829fe134d08627a9fd8e1da6
Author: Rohit Yadav <rohit.ya...@shapeblue.com>
Date:   2015-08-27T07:01:04Z

    CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template 
listing
    
    Due to aggregation of templates and isos on the UI/client side, it could 
result
    that for each page we could end up having lesser templates/isos listed to 
have
    the scroll shown that triggers infinite scrolling. The fix is to use similar
    approach as in projects.js, to use the maximum pagesize of 500. In theory, 
there
    is still a chance if there are 500 zones with the same template being listed
    resulting in only one aggregated template which could cause the scroll to 
not
    get shown; but in practice I believe this fix should work for most users.
    
    (cherry picked from commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd)
    Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to